iDevGames Forums
Including 3rd party code in source submission - Printable Version

+- iDevGames Forums (http://www.idevgames.com/forums)
+-- Forum: Community Zone (/forum-4.html)
+--- Forum: Contests (/forum-19.html)
+--- Thread: Including 3rd party code in source submission (/thread-6083.html)



Including 3rd party code in source submission - NCarter - Nov 21, 2004 06:12 PM

I'm putting my source submission archive together and I've come across an interesting problem. I'm using SDL, SDL_image and SDL_mixer, and since I needed to modify the latter two to make them work with CodeWarrior I'm going to include them in the archive. That's the easy bit. The hard part is that I'm also using WildMagic, which requires building and statically linking into the application. Rather than include a prebuilt WildMagic library and all the headers, I'd rather direct people to get their own copy from the WildMagic website.

Is this acceptable, or does the source code really have to build straight out of the archive without any extras? It seems to me that it's a bit of a waste of bandwidth to include so much extra 3rd party code in my source archive.

Incidentally, I have made a slightly modified version of WildMagic which makes things much faster by eliminating excessive use of memcpy(). However, this isn't required to build my game; the original version works just as well.


Including 3rd party code in source submission - PowerMacX - Nov 22, 2004 08:11 PM

I included the installers for SDL, SDL_image and SDL_mixer, which take about 95% of the compressed file size (1.1MB). I did not include SDL source, since I used the included installers (in fact, I couldn't even compile SDL from source!). But, for what I understand, the license requires me to "offer" to send it, so I added my email. I just hope no-one does, since the included links to the official download sites will work just fine.
I'm waiting for Carlos to send me an "source received" email.


Including 3rd party code in source submission - MattDiamond - Nov 22, 2004 10:09 PM

I believe the source needs to compile "out of the box."

I have some third party code (not libraries though.) I put notes in my license file explaining that a few of the files were not mine alone, and not necessarily covered by my open source license. Each source file is clearly marked as either being mine or not. In some cases the file is mine but I make sure to credit the original author, even if they released it for unrestricted use and I made significant modifications.

In your case, I'd just create a PROGRAMMER README.txt file at your toplevel as a roadmap to your source code, and explaining where more up-to-date versions of the contributed files can be found.


Including 3rd party code in source submission - aaronsullivan - Nov 22, 2004 10:21 PM

PowerMacX: The way I understand it (and I once thought as you did), you only need to provide a place to download SDL from your site IF you altered the SDL code and compiled your own version that is used in the game, otherwise a link to the SDL site is fine.


Including 3rd party code in source submission - PowerMacX - Nov 22, 2004 10:33 PM

I know, and I am using the standard SDL, SDL_mixer, and SDL_image frameworks. The thing is, even though I haven't touched those libraries' source code, I did edit "SDL Main.m". This of course doesn't mean I modified the real source code, but I did modify "code" which came with SDL, so I wasn't sure.

I'm still waiting to hear from Carlos (did you receive my entry source code?)


Including 3rd party code in source submission - aaronsullivan - Nov 22, 2004 10:42 PM

I wouldn't worry about that. The things we changed in the SDL Main are already in the current snapshot of the CVS version you can download from the site and swapping in a new framework would not change the SDL Main anyway. The idea is to make your game forward compatible with new versions of SDL. Changing SDLmain the way we did won't break that. Smile